MiniProfiler / rack-mini-profiler

Profiler for your development and production Ruby rack apps.
MIT License
3.68k stars 400 forks source link

Don't touch HTTP headers where possible #616

Open nate-at-gusto opened 1 month ago

nate-at-gusto commented 1 month ago

Even if disable_caching is on, we still overwrite the applications HTTP cache headers.

This can make HTTP caching difficult to observe in development mode. I understand why we have hacks and workarounds here, but it would be better if we could avoid touching this stuff and let the app do it's thing.

suryanarayanan035 commented 3 weeks ago

Hello @nate-at-gusto , we are modifying the HTTP header to prevent browser from storing cache only if disable_caching is on. So, I don't find any problems with adding no-store to HTTP header if disable caching is on and feel like its the right thing to do.

If you still find that we need to prevent modifying HTTP headers, then can you please explain me the problem we will be facing here if we just let it be?