search

Minishlink / web-push-bundle

Bundle around the WebPush library
MIT License
45 stars 10 forks source link

Raise version of minishlink/web-push to ^5.0 #16

Closed juliusstoerrle closed 4 years ago

juliusstoerrle commented 4 years ago

Alternative to #15

Minishlink commented 4 years ago

Have you tested it?

juliusstoerrle commented 4 years ago

I have tested it with my prototype which at the moment only injects the service and sends a test message to two endpoints. I also ran the bundles unit test.

Is it correct that you need to iterate over the returned generator to actually send the message? (As soon as I do that, it works as before)

Minishlink commented 4 years ago

Yes, see https://github.com/web-push-libs/web-push-php/releases/tag/v5.0.0 :)

juliusstoerrle commented 4 years ago

I saw those but it wasn't immediatly clear that I MUST iterate over the generator. It makes sense, but I first thought it is only required to get the results.

Minishlink commented 4 years ago

Ok, thanks, I edited the changelog.