Minitour / AZTabBarController

A custom tab bar controller for iOS written in Swift 4.2
MIT License
348 stars 65 forks source link

BadgeAppearnce typo? -> build errors #29

Closed peterlbrooks closed 6 years ago

peterlbrooks commented 6 years ago

/// The appearance of the notification badge. open var notificationBadgeAppearance: BadgeAppearnce = BadgeAppearnce()

Minitour commented 6 years ago

@peterlbrooks do pod update

peterlbrooks commented 6 years ago

To support swift 3 not 4 which max version should I add to the podfile (pod 'AZTabBarController', '< ?.??' if any?

Minitour commented 6 years ago

@peterlbrooks the latest version that supports swift 3.0 is 1.3.0.

Minitour commented 6 years ago

@peterlbrooks Here is your solution:

pod 'AZTabBar', '1.3.0'
pod 'EasyNotificationBadge', '1.1.1'

These are both compatible with Swift 3.2 and each other. let me know if you got it to work.

peterlbrooks commented 6 years ago

Seem to get 2 msgs - Could not infer type for 'notificationBadgeAppearance', and Use of undeclared type 'BadgeAppearnce' at

open var notificationBadgeAppearance: BadgeAppearnce = BadgeAppearnce()

pod update results are:

and in my viewcontroller:

Minitour commented 6 years ago

If the word BadgeAppearance is misspelled then you are not using 1.3.0:

https://github.com/Minitour/AZTabBarController/blob/d9ad21d015306528b86112c4ffa44c5fd7858d0b/Sources/AZTabBarController.swift#L160

However I will look into it.

Minitour commented 6 years ago

Ok I just created a new project with this podfile:

# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'FrameworkDemo' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for FrameworkDemo
  pod ‘AZTabBar’, ‘1.3.0’
  pod ‘EasyNotificationBadge’, ‘1.1.1’
end

And it compiled perfectly normal.

peterlbrooks commented 6 years ago

I will look into this later today then. Thanks for your quick support!

Minitour commented 6 years ago

No problem, be sure to update me when you figure it out.

peterlbrooks commented 6 years ago

Will re-try in a few days. I assume that it will be working per your comment, so will close this issue.