Alright, I'll try to close off this redesign marathon with one final issue.
For reference, by "improvements" I'm refering to the suggestions made in the following issues:
62
64
65
66
67
68
69
@jopperm @eyck Please review this diff, in which I rewrote the RV32I description using all of the aforementioned improvements. I realize it is a lot of text, but please read the whole thing as I have left lots of comments detailing my rationale for certain decisions and how the new syntax improves readability.
I would like to note that the original implementation was incorrect and incomplete in many places, so it looks more consise than it would have been, had it been implemented correctly (lots of missing casts that have been replaced by truncate and the like).
If you want to play around with it, a fully functioning prototype implementation of all of this can be found on this branch.
I think it would be a good idea to schedule a Zoom meeting as soon as possible, so we can talk through all of these points. I imagine trying to coordinate this many changes just via GitHub comments could become confusing quickly.
I honestly believe this is a good direction for CoreDSL to take, as the user experience suffers heavily from some of the design choices made in the past. And since I basically am our frontend team, I see it as part of my responsibility to keep an eye on these things.
... and now I will get some sleep. Didn't even intend to work today, it just kind of happened 😄
Alright, I'll try to close off this redesign marathon with one final issue. For reference, by "improvements" I'm refering to the suggestions made in the following issues:
62
64
65
66
67
68
69
@jopperm @eyck Please review this diff, in which I rewrote the RV32I description using all of the aforementioned improvements. I realize it is a lot of text, but please read the whole thing as I have left lots of comments detailing my rationale for certain decisions and how the new syntax improves readability. I would like to note that the original implementation was incorrect and incomplete in many places, so it looks more consise than it would have been, had it been implemented correctly (lots of missing casts that have been replaced by
truncateand the like).If you want to play around with it, a fully functioning prototype implementation of all of this can be found on this branch.
I think it would be a good idea to schedule a Zoom meeting as soon as possible, so we can talk through all of these points. I imagine trying to coordinate this many changes just via GitHub comments could become confusing quickly.
I honestly believe this is a good direction for CoreDSL to take, as the user experience suffers heavily from some of the design choices made in the past. And since I basically am our frontend team, I see it as part of my responsibility to keep an eye on these things.
... and now I will get some sleep. Didn't even intend to work today, it just kind of happened 😄