MinusKube / SmartInvs

Advanced Inventory API for your Minecraft Bukkit plugins.
https://minuskube.gitbook.io/smartinvs/
Apache License 2.0
263 stars 65 forks source link

Compiling the spigot-api #213

Open SimonTheSiro opened 2 years ago

SimonTheSiro commented 2 years ago

Hi there,

I've used SmartInvs and it works quite well. It was only when I changed the API of my plugin from spigot to paper that I noticed that Maven compiles the Minecraft server afterwards.

So I looked in the pom.xml of SmartInvs and found:

<dependency>
      <groupId>org.spigotmc</groupId>
      <artifactId>spigot-api</artifactId>
      <version>1.8.8-R0.1-SNAPSHOT</version>
      <scope>compile</scope>
</dependency>

That means I need to override the spigot-api with the scope provided so it doesn't compile with:

<dependency>
      <groupId>org.spigotmc</groupId>
      <artifactId>spigot-api</artifactId>
      <version>1.16.5-R0.1-SNAPSHOT</version>
      <scope>provided</scope>
</dependency>

As I said before, when I use the Paper API, the server is compiled with:

<dependency>
      <groupId>com.destroystokyo.paper</groupId>
      <artifactId>paper-api</artifactId>
      <version>1.16.5-R0.1-SNAPSHOT</version>
      <scope>provided</scope>
</dependency>

Is that intentional, or is it a mistake?

I would like to know, because the server already has the classes :D, so the plugin doesn't need to compile them, does it?

-Siro