search

Miserlou / RJModules

Various modules for VCV Rack
https://github.com/Miserlou/RJModules
MIT License
99 stars 18 forks source link

Issue #67 Instro add crash fix #70

Closed SteveRussell33 closed 4 years ago

SteveRussell33 commented 4 years ago

Fix for https://github.com/Miserlou/RJModules/issues/67

SteveRussell33 commented 4 years ago

I understand your fix but can I ask how would it break development as the plugins-v1 folder name is from Rack itself? https://github.com/VCVRack/Rack/blob/v1/plugin.mk#L74

david-c14 commented 4 years ago

I was thinking of when I do make run Rack runs in the Rack directory, and looks for plugins in the Rack/plugins directory. So swapping the value of the macro just swaps the problem from one place to another.
But I could be wrong.

SteveRussell33 commented 4 years ago

Closing as path is relative to executable folder and not plugins folder.