MisterPeModder / Bomberman-Global-Offensive

Probably one of the best Bomberman fan games
MIT License
4 stars 3 forks source link

Cleanup bomb creations #225

Closed AndreasLrx closed 2 years ago

AndreasLrx commented 2 years ago

Bomb creation is now centralized in Bomb.cpp

Some Debug code is left in Collision.cpp because it will be used to resolve issue #211.

codecov-commenter commented 2 years ago

Codecov Report

Merging #225 (c46935a) into master (1ff759a) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   11.43%   11.42%   -0.02%     
==========================================
  Files         166      166              
  Lines        2737     2740       +3     
  Branches      902      898       -4     
==========================================
  Hits          313      313              
- Misses       2274     2277       +3     
  Partials      150      150              
Impacted Files Coverage Δ
src/game/components/Bomb.cpp 0.00% <0.00%> (ø)
src/game/components/Bomb.hpp 0.00% <ø> (ø)
src/game/components/Player.cpp 0.00% <0.00%> (ø)
src/game/components/Player.hpp 0.00% <ø> (ø)
src/game/components/items/LandMine.cpp 0.00% <0.00%> (ø)
src/game/systems/Collision.cpp 0.00% <0.00%> (ø)
src/game/components/Position.hpp 0.00% <0.00%> (ø)
src/game/components/Velocity.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ff759a...c46935a. Read the comment docs.