search

MitchBarnett / wiki-bank-tag-integration

Allows the creation of bank tags from categories on the offical OSRS wiki
BSD 2-Clause "Simplified" License
9 stars 13 forks source link

Monster Drops functionality appears to be broken. #10

Open sinoah opened 2 years ago

sinoah commented 2 years ago

Possibly a wiki update that may have broken this.

image

tikeyike commented 2 years ago

It appears to still be broken when using the drop command. The cat command still works.

CalebWhiting commented 2 years ago

I've submitted a pull request which fixes this, hopefully the maintainer will get around to it soon.

SatisChrisM commented 2 years ago

Any update to the Pull request? drops functionality is still broken :(

MitchBarnett commented 2 years ago

I thought it has been fixed actually, I can try to have a look at some point but I don't know when.

SatisChrisM commented 2 years ago

Oh perfect. No Rush mate. Appreciate it is only a side project!

Ben10164 commented 1 year ago

I thought it has been fixed actually, I can try to have a look at some point but I don't know when.

It seems the Runelite plugin-hub is still using commit 233f143f

Screen Shot 2022-12-13 at 1 07 26 PM
ragsmaroon commented 1 year ago

I thought it has been fixed actually, I can try to have a look at some point but I don't know when.

It seems the Runelite plugin-hub is still using commit 233f143

Screen Shot 2022-12-13 at 1 07 26 PM

Good catch, hopefully means whenever he gets the chance to push it to runelite it should be fixed :) Love this plugin so it's been a bit of a loss

monkeyd57 commented 1 year ago

any update on this? seems very interesting!

Nick2bad4u commented 1 year ago

I've submitted a pull request which fixes this, hopefully the maintainer will get around to it soon.

Maybe you could Fork the plugin and fix it yourself if the author is MIA

Osamu01 commented 1 year ago

I thought it has been fixed actually, I can try to have a look at some point but I don't know when.

Please update to runelite! This is such a huge plugin...

Nick2bad4u commented 1 year ago

Anyone want to work together and fork the plugin and fix it?

Robbiecs910 commented 8 months ago

Has there been any updates to this as I would love to use the Drops function of the plugin. Thanks,

Osamu01 commented 3 months ago

https://github.com/runelite/plugin-hub/pull/6077#issuecomment-2131358881 If you're a developer capable of updating this consider checking out how to do so here. Wish I could.

steveacalabro commented 3 months ago

On it

Osamu01 commented 3 months ago

On it

I appreciate you so much brother. About 1 year now I've been looking forward to seeing this fixed. Best wishes.

Nick2bad4u commented 3 months ago

On it

I appreciate you so much brother. About 1 year now I've been looking forward to seeing this fixed. Best wishes.

SAME!

steveacalabro commented 3 months ago

Tested 491d7054b3dfb34f66e7c30ed66712a973086128 locally and it works.

Forked the plugin-hub repo and it appears the commit being used is this

233f143f9994558bb44696411eccc6fd74d92d88

I updated that to match the latest commit on this repo 491d7054b3dfb34f66e7c30ed66712a973086128

That PR has been submitted to the plugin hub repo here

steveacalabro commented 3 months ago

Update: The build failed due to an outdated bit of code in the repo. I made a new PR to this repo, once approved and merged I can update plugin-hub

https://github.com/MitchBarnett/wiki-bank-tag-integration/pull/17

Nick2bad4u commented 3 months ago

Update: The build failed due to an outdated bit of code in the repo. I made a new PR to this repo, once approved and merged I can update plugin-hub

17

You might have to fork it and re-submit it as a new plugin. I dont think the plugin author will merge it in as hes been MIA for a long time!

Ben10164 commented 3 months ago

You might have to fork it and re-submit it as a new plugin. I dont think the plugin author will merge it in as hes been MIA for a long time!

I remember asking Adam or some other popular mantainer about this a while ago, and they said that we would need to get permission to replace the other one. Like we can't have multiple plugins in the plugin hub that claim to do the same thing, with one working and one not. We can always contact maintainers again and ask if we can force an update.

Nick2bad4u commented 3 months ago

You might have to fork it and re-submit it as a new plugin. I dont think the plugin author will merge it in as hes been MIA for a long time!

I remember asking Adam or some other popular mantainer about this a while ago, and they said that we would need to get permission to replace the other one. Like we can't have multiple plugins in the plugin hub that claim to do the same thing, with one working and one not. We can always contact maintainers again and ask if we can force an update.

I assume the process would involve delisting this one no? having broken addons in the plugin library is messy

steveacalabro commented 3 months ago

Yeah I spoke with the runelite devs in the PR for plugin-hub. Seems like we need to repair this plugin by updating it to the latest standard and then contact the original author and get it re-submitted or added as maintainers to the repo. I sent an email to them, I'm about to go on vacation for a week. I do have the plugin re-written on my local but was testing some things that are different with parsing the response from the wiki. Once I return, the plan was to make a new PR again to this repo that rewrites everything and brings it up to standard then i was going to send another email to the author and see what we can do. Wanted to make it simple for them like "hey here's this full thing that is done, just need you to publish"

MitchBarnett commented 3 months ago

Just to say I am aware of the comments here I'm not able to resolve this right now now as I only have a mobile device but I should be able to review this later in the week potentially I may be able to look tomorrow.

steveacalabro commented 3 months ago

Ayyyy! @MitchBarnett thank you thank you. Like I said, just ignore the PR I have there for now. I'll have an updated one in a weeks time and it'll fix everything for ya

Nick2bad4u commented 3 months ago

Just to say I am aware of the comments here I'm not able to resolve this right now now as I only have a mobile device but I should be able to review this later in the week potentially I may be able to look tomorrow.

You should be able to easily merge the PR from the github mobile website or app. If not, you can also give someone else permission to merge things. Thanks for not abandoning it!

Lorentary commented 2 months ago

This might be a bit early - but are there any updates?

monkeyd57 commented 1 month ago

also interested on the progress as ive noticed its not in the hub anymore. very interested

Nick2bad4u commented 1 month ago

also interested on the progress as ive noticed its not in the hub anymore. very interested

Same :(

Osamu01 commented 6 days ago

@MitchBarnett I sympathize with your current limitations/situation, but I digress it's been 3 months since you said a week, 2 years since you said you'd take a look. Could you perhaps go ahead and push a fix or let someone else take over the plugin? It's a great plugin you've made.

Nick2bad4u commented 6 days ago

@MitchBarnett I sympathize with your current limitations/situation, but I digress it's been 3 months since you said a week, 2 years since you said you'd take a look. Could you perhaps go ahead and push a fix or let someone else take over the plugin? It's a great plugin you've made.

Agreed. I would love to take it over but Im not sure RuneLite devs would let me copy the plugin without permission. I think the old one would need to be delisted.