Closed thewatts closed 6 years ago
Hey @thewatts, thanks for your very extensive pull request. I'm sorry it's taken a while for someone to get back to you about it!
On a quick first read through, it seems like there are some helpful additions and amendments. I will try and find some time a bit later to give it a full review, as there are a lot of changes 😉
Hey @robinnorth - thanks for the feedback!
I'm going through your suggestions and will add another commit with the fixes :)
@robinnorth - feedback commit added :)
@robinnorth Thank You for looking at everything, and for your work on this project. I'm very much enjoying working with it!
@thewatts Thank you for making those changes.
There are a few remaining comments. Can you take a look at those?
@BehindTheMath - I've made those adjustments, and rebased the commit.
Let me know if there's anything else you need!
@BehindTheMath oh sorry I missed those! I never received email notifications of the additional requests.
Working on them right now -
@BehindTheMath all set!
Thanks for this awesome project!
I spent some time really digging into the README to learn in the ins/outs of how everything works.
These changes are just some suggestions based on my experience going through the docs.
100% no pressure to use them, but thought they might be helpful.