MoOx / pjax

Easily enable fast Ajax navigation on any website (using pushState + xhr)
MIT License
1.46k stars 125 forks source link

README suggestions #176

Closed thewatts closed 6 years ago

thewatts commented 6 years ago

Thanks for this awesome project!

I spent some time really digging into the README to learn in the ins/outs of how everything works.

These changes are just some suggestions based on my experience going through the docs.

100% no pressure to use them, but thought they might be helpful.

robinnorth commented 6 years ago

Hey @thewatts, thanks for your very extensive pull request. I'm sorry it's taken a while for someone to get back to you about it!

On a quick first read through, it seems like there are some helpful additions and amendments. I will try and find some time a bit later to give it a full review, as there are a lot of changes 😉

thewatts commented 6 years ago

Hey @robinnorth - thanks for the feedback!

I'm going through your suggestions and will add another commit with the fixes :)

thewatts commented 6 years ago

@robinnorth - feedback commit added :)

thewatts commented 6 years ago

@robinnorth Thank You for looking at everything, and for your work on this project. I'm very much enjoying working with it!

BehindTheMath commented 6 years ago

@thewatts Thank you for making those changes.

There are a few remaining comments. Can you take a look at those?

thewatts commented 6 years ago

@BehindTheMath - I've made those adjustments, and rebased the commit.

Let me know if there's anything else you need!

BehindTheMath commented 6 years ago

There are a few more comments (here, here, here, and here).

thewatts commented 6 years ago

@BehindTheMath oh sorry I missed those! I never received email notifications of the additional requests.

Working on them right now -

thewatts commented 6 years ago

@BehindTheMath all set!