Add time unit to duration offsets

MobilityData / gtfs-flex

NOTICE: GTFS-Flex has been merged to GTFS. This repo is no longer up-to-date and will deprecated. Consult the google/transit repo for the up-to-date info.

https://github.com/google/transit

Apache License 2.0

119 stars 24 forks source link

Add time unit to duration offsets #47

Closed timMillet closed 3 years ago

timMillet commented 3 years ago

A time unit should be assigned to mean_duration_offset and safe_duration_offset. In this PR, the second is the time unit assigned to these 2 fields.

CLAassistant commented 3 years ago

All committers have signed the CLA.

westontrillium commented 3 years ago

I definitely agree that we should define a unit of time here, however, Trillium (producer) and OTP (consumer) understand these fields as minutes, not seconds.

timMillet commented 3 years ago

@westontrillium Do you mean that Trillium is already producing GTFS-FlexibleTrips data, OTP is already consuming GTFS-FlexibleTrips data, and both used the time unit "minute" for implementing this field?

westontrillium commented 3 years ago

@timMillet Yes. However, I will note that this is all occurring in a test environment at this point.

timMillet commented 3 years ago

@westontrillium Thanks for your answer! I changed the time unit based on your implementation.

Does anyone else would like to provide their feedback before I merge?

timMillet commented 3 years ago

Thanks for your feedback! I'm merging this PR into gtfs-flex/master