search

Mobiperf / MobiPerf

New MobiPerf Repository
http://mobiperf.com
Other
87 stars 63 forks source link

Add properly IO handling on close. #159

Closed cmdln closed 10 years ago

cmdln commented 10 years ago

On the M-Lab platform, we are seeing fairly chronic errors. I cleaned up the IO handling, especially to move close attempts to a finally block to ensure they are always attempted and hence underlying OS resources less likely to be left in inconsistent states.

dmah42 commented 10 years ago

+1 to this change

drchoffnes commented 10 years ago

We are testing it first, and plan to merge/deploy after that.

On Tue, Sep 2, 2014 at 3:05 PM, Dominic Hamon notifications@github.com wrote:

+1 to this change

— Reply to this email directly or view it on GitHub https://github.com/Mobiperf/MobiPerf/pull/159#issuecomment-54201459.

cmdln commented 10 years ago

Fantastic, thank you!

morleymao commented 10 years ago

Hongyi will take care of merging/deploying.

laoyaosniper commented 10 years ago

Hi Dave and Morley,

I have deployed and tested the new tcp server for several days. It works as expected. I think we can merge this pull request to our main branch.