search

ModOrganizer2 / modorganizer

Mod manager for various PC games. Discord Server: https://discord.gg/ewUVAqyrQX if you would like to be more involved
http://www.nexusmods.com/skyrimspecialedition/mods/6194
GNU General Public License v3.0
2.23k stars 163 forks source link

Add 'isLight' methods to IPluginList API and python stubs #1669

Open mdavis199 opened 2 years ago

mdavis199 commented 2 years ago

The methods isLight and isLightFlagged are part of pluginlist.h public interface but not part of the IPluginList API. These would come in handy for MO2 Plugins that help with merging.

Presently, I'm having to open and read the entire plugin, then parse the contents with a third-party library -- just to determine if the plugin is 'light' or not.

Could you add these to the API and python stubs, pretty please?

https://github.com/ModOrganizer2/modorganizer/blob/25cdbe3918d911074f1f556b63bdd305554da22a/src/pluginlist.h#L236-L237

https://github.com/ModOrganizer2/modorganizer/blob/e78f46cc9ec440a04e8421d150d114db2ca6810d/src/pluginlist.cpp#L936-L954

qudix commented 2 years ago

I'll take a look when I have the time later today or tomorrow. I just need to add the methods to uibase, mod organizer, and the python plugin I think. I might also throw in isMasterFlagged just for completeness' sake.