search

ModelOriented / ingredients

Effects and Importances of Model Ingredients
https://modeloriented.github.io/ingredients/
GNU General Public License v3.0
37 stars 18 forks source link

Default loss_function for feature_importance #117

Closed maksymiuks closed 4 years ago

maksymiuks commented 4 years ago

Once DALEX 1.2.2 hits master, it will support multiclass classification. I suggest small rework for feature_importance.explainer() so function checks the explainer$model_info$type and uses loss_cross_entropy or loss_one_minus_auc accordingly to multiclass and classification types.

pbiecek commented 4 years ago

once this is added, let's force user to use specific versions fo DALEX (>=1.2.2) and ingredients (>=1.2.2) to keep consistency between sets of packages

hbaniecki commented 4 years ago

Good idea, but this enforcement will only work one way (meaning DALEX 1.2.2 will force ingredients 1.2.2).

pbiecek commented 4 years ago

added to ver 1.3