Description

Changed the way model.add_cmeta_id(var) determines what to use as cmeta_id to using display_name

Motivation and Context

According to https://www.w3.org/TR/xml11/#NT-Nam the $ carachter is not allowed in IDs using the display_name function gets a consitent name, in fact the string version with $ replaced since there is no metadata (else there would have been a cmeta_id)

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated all documentation necessary.
[ ] I have checked spelling in (new) comments.

n/a

Testing

[X] Testing is done automatically and codecov shows test coverage
[ ] This cannot be tested automatically

Codecov Report

Merging #283 into develop will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #283   +/-   ##
========================================
  Coverage    97.57%   97.57%           
========================================
  Files            7        7           
  Lines         1359     1359           
  Branches       295      295           
========================================
  Hits          1326     1326           
  Misses          15       15           
  Partials        18       18

Impacted Files	Coverage Δ
cellmlmanip/model.py	`99.78% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d09be9f...6b5765d. Read the comment docs.

ModellingWebLab / cellmlmanip