removed unneeded line - Githubissues

ModellingWebLab / cellmlmanip

CellML loading and model equation manipulation

Other

3 stars 1 forks source link

removed unneeded line #285

Closed MauriceHendrix closed 4 years ago

MauriceHendrix commented 4 years ago

Description

I removed the line cf = self.create_quantity(cf, units / original_variable.units) from the convert function

Motivation and Context

It doesn't seem needed and was causing issues in chaste_codegen

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated all documentation necessary.
[ ] I have checked spelling in (new) comments.

Testing

[X] Testing is done automatically and codecov shows test coverage
[ ] This cannot be tested automatically

Also tested chaste_codegen with the change