search

ModernFlyouts-Community / ModernFlyouts

A modern Fluent Design replacement for the old Metro themed flyouts present in Windows.
https://modernflyouts-community.github.io
MIT License
3.55k stars 191 forks source link

Feature Request:When there are two media panels from the same program, the panel with playback information is preferred #244

Open ShangJixin opened 3 years ago

ShangJixin commented 3 years ago

Is your feature request related to a problem? Please describe:

When there are two control panels from the same program, the panel with playback information is preferred.

Panel 1 is not have music infomation ↑ Panel 1 is not have music infomation

panel 2 have music infomation, But the first is always displayed by default Panel 2 have music infomation，But the first（panel 1） is always displayed by default，and both panels come from one program

Describe alternatives you've considered:

I know the problem is the music player itself. It would be better if modernflyouts could be optimized in another way.

Additional context:

Please forgive my poor English....

ShankarBUS commented 3 years ago

What is the music player.

Give me a link to the player's website so that I can test it.

ShangJixin commented 3 years ago

@ShankarBUS

https://www.microsoft.com/zh-cn/p/qq%e9%9f%b3%e4%b9%90/9wzdncrfj1q1?activetab=pivot:overviewtab

You may have to switch the region to "China" to install this player.

Thank you very much!!

ShankarBUS commented 3 years ago

Does this issue happen with Windows default one too?

If the Windows default flyout also show two panels, then there must be problems with the media player itself.

ShangJixin commented 3 years ago

image In default, Windows can automatic to choose the right one.

ShankarBUS commented 3 years ago

But there are 2 panels even in the Windows default flyout.

Thanks for reporting! I'll fix it as quick as possible 😄.

prakharb5 commented 3 years ago

I think we can create an argument which favours the media panel from the app which has more information.

ShankarBUS commented 3 years ago

@Cyberdroid1,

Did you know that there is something to consider while developing apps called "performance"?

Doing comparisons while enumerating the sessions would would degrade the performance down to oblivion. Also there is no way to compare sessions while they're being enumerated.

So a big no no.

But there is a property called CurrentSession in GSMTC manager. It could be used somehow.

prakharb5 commented 3 years ago

Comparing the provided info as text drops performance?? Oh

ShankarBUS commented 3 years ago

Not when they're done only once.

But if we did like you said.

We would need to compare all sessions when any one has a change like playback status, media info, timeline info. So, the comparison will happen atleast every second.

Think of it.

prakharb5 commented 3 years ago

What about doing this process only when new media sessions are detected?