search

MolSSI / cookiecutter-cms

Python-centric Cookiecutter for Molecular Computational Chemistry Packages
MIT License
385 stars 89 forks source link

Update for NEP #146

Closed mikemhenry closed 2 years ago

mikemhenry commented 2 years ago

Drop python 3.7 from testing matrxi and add python 3.10, using quotes to avoid yaml parsing issues

janash commented 2 years ago

@Lnaden - Considering that Python 3.10 is the standard on the Python docs, I think we should merge this.

Lnaden commented 2 years ago

I do agree this idea needs to be merged, but not this PR

This PR only changes one reference file, not the actual output. I'll take care of this today or tomorrow with a separate PR that adjusts all the files needed.

janash commented 2 years ago

Ah, right. Yes, the appropriate file needs to be changed.

mikemhenry commented 2 years ago

Does everything in github/reference-workflows/* need to be fixed as well? Now I have updated the template.

Lnaden commented 2 years ago

Yes. The template file needed to be updated, and the references can be regenerated with https://github.com/MolSSI/cookiecutter-cms/blob/master/tests/regenerate_references.sh no need to do it by hand (in fact dont do it by hand)

mikemhenry commented 2 years ago

@Lnaden That should do it, I think you have to approve CI to run since this is my first time contributing to the repo.

codecov[bot] commented 2 years ago

Codecov Report

Merging #146 (b505551) into master (918de2a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files          12       12           
  Lines          78       78           
=======================================
  Hits           48       48           
  Misses         30       30
Flag Coverage Δ
unittests 61.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 918de2a...b505551. Read the comment docs.