MolSSI / mmic_openff

Tactic MMIC translator for OpenFF/MMSchema
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Multiple conformers #4

Open anabiman opened 2 years ago

anabiman commented 2 years ago

Currently MMSchema does not handle multi-conformers (whereas OpenFF toolkit does). What is the best way to handle this disrepancy?

1 - Add another dimension to Molecule.geometry ? This would make Molecule overlap with Trajectory to some degree but would make Molecule a relevant output to equilibrium MM computations as well. It seems like a neat solution. 2 - Have mmic_translator optionally return multiple Molecule objects? This would make the process of translation between MMSchema and other codes/specs a bit awkward and less rigorous. 3 - Populate the Molecule.extras field with any extra conformers? This is a temporary solution but may last a while as long as every MM code does things in its own way.

j-wags commented 2 years ago

This is a big decision. I'd vote for

Have mmic_translator optionally return multiple Molecule objects?

My reasoning is: