search

Molecular-Biophysics-Database / mbdb-app

The complete application
MIT License
0 stars 0 forks source link

The user doesn't know when file uploading has completed #356

Open JanDohnalek opened 1 week ago

JanDohnalek commented 1 week ago

When attaching a 73 MB binary file, everything worked fine (an .mtz type but I guess it does not matter here). It could provide back the file upon request.

When attaching a ~ 50 MB binary file (.mrc type), it "saved" not saying a word but then in preview when attempting to download, it says status 404 message "Record 'qan39-t3775' has no file 'run_class001_jakoStateII.mrc'."

Is there an internal frontend, backend check in place which filters "dangerous" files, i.e. with code in it? This does not seem to be connected to file size but rather perhaps to its typ/content? Do we have a size limit? If yes, the tooltip should mention that.

NOT CRITICAL NOW - I did not see this with the usual file sizes we produce ...

edager commented 2 days ago

This needs to be addressed by either:

  1. Telling the user when uploading of the file has completed
  2. Freeze the input form while file is uploading (or make the PUT request a synchronous process instead)

Otherwise they might leave the input form which results in a half uploaded broken file, that causes errors in the record view.