search

Momo-Softworks / Cold-Sweat

Other
54 stars 21 forks source link

Custom Hotbar shifts entire ui downward (1.20.1) #411

Closed GoldeRuby closed 1 day ago

GoldeRuby commented 5 days ago

i want to get this clear first: switching off the [Custom Hotbar] setting in the built-in config fixes this issue, but it took me a good while to figure out what exactly was the problem was to begin with

as the title says, having the Custom Hotbar enabled shifts the entire ui downward by a few pixels image on its own, its not that serious of an issue, but it only visually shifts down the ui, the actual buttons are where they normally are

however, the ui being moved seems to significantly disagree with REI image again, the actual ui visuals are disconnected from the actual button locations

MikulDev commented 4 days ago

What mods are you using? This doesn't happen for me on a "Vanilla" instance, so it might be a conflict. I have an idea of what the issue is and how to solve it, but I don't know for sure.

GoldeRuby commented 4 days ago

What mods are you using?

it very well could be a conflict, and wouldnt shock me if it is unfortunately, the pack i made is 95 mods (counting dependencies) could you maybe say what your idea is? i think that would be easier than me dissecting through my folder to discern content from libraries to make a list

MikulDev commented 3 days ago

I would need all of your mods to do a proper test anyway, dependencies and all. I can try to explain it to you, but it's a bit technical.

Basically, UI elements and menus are positioned using a PoseStack, which holds a series of relative transformations. This is used as a "reference point" that tells the game where things should be rendered on-screen. There is only one PoseStack that everything shares, meaning that when a UI element is rendered, it manipulates the stack as needed, then passes it along to the next UI element.

You're supposed to "pop" the stack, which resets the transformations you just performed so they aren't carried over to the next thing being rendered. I assumed this was already being done, but it might not be. The result is that when the XP level graphic is shifted down, everything rendered after that point is shifted down as well, which could cause what you're seeing here.

GoldeRuby commented 1 day ago

that makes sense, i think i have a drive link from when i sent it over to a friend (somehow the pack export exceeded Discord's limit so i resorted to Drive)

here it is: link it should be set so it just needs the link to share

MikulDev commented 1 day ago

Thanks for sending the pack. I was able to test my solution and it worked, so expect this to be solved in 2.3.9