search

Mongey / terraform-provider-confluentcloud

A Terraform provider for managing resource in confluent.cloud
MIT License
110 stars 47 forks source link

Fix schema registry resource #182

Closed Mongey closed 2 years ago

Mongey commented 2 years ago

Fixes #179

lorelei-rupp-imprivata commented 2 years ago

@Mongey so what was the root cause here, what broke that required fixing?

Mongey commented 2 years ago

@lorelei-rupp-imprivata the underlying http library expected the "Name" attribute of a schema registry to match the Id. I updated it to just look for the actual Id. https://github.com/Mongey/go-client-confluent-cloud/commit/d1ffb9b0c486bab32b03a6c0204eef36f615aacc

lorelei-rupp-imprivata commented 2 years ago

@lorelei-rupp-imprivata the underlying http library expected the "Name" attribute of a schema registry to match the Id. I updated it to just look for the actual Id. Mongey/go-client-confluent-cloud@d1ffb9b

Thanks - Interesting. I thought the go library would require an update. Do you think this is related to Confluents refactor https://github.com/confluentinc/schema-registry/pull/2332/files

Mongey commented 2 years ago

Thanks - Interesting. I thought the go library would require an update.

Yeah, the go library did require an update, I'm using a forked version over at https://github.com/Mongey/go-client-confluent-cloud/

Do you think this is related to Confluents refactor https://github.com/confluentinc/schema-registry/pull/2332/files

No, The way the http library implemented finding a schema registry just relied on looking at the wrong field. Those changes seem related to the API for actually posting schemas to the schema registry. (I think)