search

Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.18k stars 689 forks source link

Adjust Twitter window reaction to X #10211

Open dreamscached opened 6 months ago

dreamscached commented 6 months ago

https://github.com/Monika-After-Story/MonikaModDev/blob/06baf319a34c2ef585bc7c0a1e969a7eaa894b35/Monika%20After%20Story/game/script-windowreacts.rpy#L267-L282

Nuff said. Twitter is now X and the window reaction has to be adjusted. I would've created a PR myself but I'm concerned if changing the category would require a persistent modifications.

Screenshot of Monika X profile tab

Booplicate commented 6 months ago

Or we could intentionally keep it Twitter

dreamscached commented 6 months ago

My suggestion as a middle ground is to keep both, if the window reaction framework allows that.

Booplicate commented 6 months ago

Jokes aside, I'm a little afraid of porn sites reacts if we keep it as just / x

dreamscached commented 6 months ago

Weeeell... yeah. But in case of X/Twitter we could react on stuff that looks exactly like

Name (@handle) / X

If possible. That is an issue with X-sites yeah, but if we trim the string, there should just / X be left at the end?

P.S. Alternatively, why don't we just match the @lilmonix thing exactly?

TheBearodactyl commented 2 months ago

https://github.com/Monika-After-Story/MonikaModDev/blob/06baf319a34c2ef585bc7c0a1e969a7eaa894b35/Monika%20After%20Story/game/script-windowreacts.rpy#L267-L282

Nuff said. Twitter is now X and the window reaction has to be adjusted. I would've created a PR myself but I'm concerned if changing the category would require a persistent modifications.

Screenshot of Monika X profile tab

maybe just make it react to x.com but have it shown as twitter since nobody calls it "X" anyways

dreamscached commented 2 months ago

However, it's 'X' now and I think we should reflect the change. It'll sure take a while for people to move on from it (and they themselves at X kind of stall at that migration), but it's no longer Twitter really.

TheBearodactyl commented 2 months ago

However, it's 'X' now and I think we should reflect the change. It'll sure take a while for people to move on from it (and they themselves at X kind of stall at that migration), but it's no longer Twitter really.

it is twitter. if elon won't call his daughter by her prefered name, we shouldn't call Twitter X. simple as that

dreamscached commented 2 months ago

I don't think Elon's family relations are relevant in the question. The website and the company were renamed to X, officially.

TheBearodactyl commented 2 months ago

I don't think Elon's family relations are relevant in the question. The website and the company were renamed to X, officially.

loophole time :D

https://x.com/racistriamu/status/1686945859320369152

TheBearodactyl commented 2 months ago

also image_2024-06-21_160319548

dreamscached commented 2 months ago

Like I said, I do admit they stall at the migration at the moment. The frontpage however is located at x.com and their company name is 'X'.

Source 1 Source 2 (this one deserves attention)

TheBearodactyl commented 2 months ago

Like I said, I do admit they stall at the migration at the moment. The frontpage however is located at x.com and their company name is 'X'.

Source 1 Source 2 (this one deserves attention)

And like i said, who tf cares if elon wants to call it X, it's twitter and it will always be twitter.

Booplicate commented 2 months ago

@TheBearodactyl they won't get rid of the old domain because it worth a lot, it'd be a waste and many links would become dead. It's not really a proof. People call it both X and Twitter now.

I still think due to the stupid name we should probably just remove the react. The amount of false positives you get is too high. There's just 3 characters to match.

TheBearodactyl commented 2 months ago

@TheBearodactyl they won't get rid of the old domain because it worth a lot, it'd be a waste and many links would become dead. It's not really a proof. People call it both X and Twitter now.

I still think due to the stupid name we should probably just remove the react. The amount of false positives you get is too high. There's just 3 characters to match.

they did get rid of the old domain on the main site but yeah, agreed. maybe replace it with bluesky?

Booplicate commented 2 months ago

they did get rid of the old domain on the main site but yeah, agreed. maybe replace it with bluesky?

Last time I checked they still owned the domain and it still leads to X.

dreamscached commented 2 months ago

I agree with removing the react, to be honest. \@lilmonix3 is seemingly (to me) a canon thing endorsed by Team Salvato, but whoever holds the handle posts rarely and it doesn't quite (again, to me) align with MAS 'canon'.

TheBearodactyl commented 2 months ago

they did get rid of the old domain on the main site but yeah, agreed. maybe replace it with bluesky?

Last time I checked they still owned the domain and it still leads to X.

they still own the domain, but it only redirects now. it is just x.com now (except for the help page for some reason)

dreamscached commented 2 months ago

Google owns many typesquatter domains that redirect to the true one, doesn't imply we can call it 'googel' or whatever.

Booplicate commented 2 months ago

@dreamscached the lilmonix is a different react and iirc it's disabled already

they still own the domain, but it only redirects now

Which is why I said they didn't and won't get rid of it.

dreamscached commented 2 months ago

@dreamscached the lilmonix is a different react and iirc it's disabled already

I know, just mentioned it as a point towards removing this react too. I don't see a real use for it, unlike Wikipedia or MAS Discord (or do we not have a react for that? I don't remember.)

TheBearodactyl commented 2 months ago

i just opened a PR that would change Twitter to bluesky

meoowmeowman commented 1 month ago

I don't think Elon's family relations are relevant in the question. The website and the company were renamed to X, officially.

Oh please, do NOT tell me you´re supporting him? Do you like know what he´s done? On top of the sexual harassment and transphobia, he also used to have an alt account on twitter where he roleplayed as one of his kids (A 3 year old to be exact), and yes, it is sadly confirmed it was him. And on top of that the babyfur allegations.. yikes