Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.18k stars 687 forks source link

[Suggestion] More keywords for Windowreacts #4511

Closed grandsong closed 5 years ago

grandsong commented 5 years ago

Window React is a great feature which breaks the fouth wall.

However, it lacks contents badly so far.

Monika reacts to mere THREE sets of keywords from the title of your active windows:

  1. youtube
  2. rule34 + monika (see my other issue #4510)
  3. monikamoddev

They are defined in "zz_windowreacts.rpy" as category.

Three are too few.

Before I studied the script file, I had tried some sites and keywords, which I thought to be relevant.

She was not aware of any. That put a damper on me.

I hope you add categories as above.

And more, like:

Rai99 commented 5 years ago

More windowreacts are likely on the way, but do keep in mind that this is still a relatively new feature, and that they would have to be written by someone.

You would also have to understand that there's no way we can include a reaction for each and every possible scenario.

If you like, feel free to add these and PR them for yourself.

grandsong commented 5 years ago

Thanks for you quick reply, @Rai99.

I did tried to make my own PR, but

  1. Somehow my Git Client failed to clone the repo (either my fork or this original repo), again and again. So I gave up.

  2. My suggestion is just a source (or pool?) of inspiration. I'm sure other people and @multimokia will be willing and able to contribute.

  3. I'm not a native English speaker. I don't think I can be good at adding contents of how Monica reacts.

multimokia commented 5 years ago

Fyi, there are more windowreacts in already #4379, #4384, #4375.

These cover some of your suggestions

multimokia commented 5 years ago

Keywords like "gift", "poem", "python", "renpy", "piano", etc, which are interested by her.

Some of these are harder than others because of how open ended a single word can be, so it's hard to get an accurate response here.

When I edit files under DDLC game folder in a code editor (I use Sublime Text mostly), or any .rpy files, she will see the file path in window title and give some reactions.

This is mainly what the monikamoddev one was for. It was the best way to filter out specifically our files, since (at least in visual studio code) it shows the folder workspace in the window handle, and the repo is called monikamoddev.

ThePotatoGuy commented 5 years ago

yeah as usual, we're contributor driven, so the goal is users add additonal reacts as they see fit.

[closing]

SonicEraZoR commented 4 years ago

@grandsong Hey, I actually did open a pull request for YOU and ME and HER window reactions #6007, so check out if you're interested! Btw, I'm non-native english speaker too but I still was able to write some simple reactions

grandsong commented 4 years ago

@grandsong Hey, I actually did open a pull request for YOU and ME and HER window reactions #6007, so check out if you're interested! Btw, I'm non-native english speaker too but I still was able to write some simple reactions

I'm afraid you misunderstand how the keywords work. As @multimokia said,

Some of these are harder than others because of how open ended a single word can be, so it's hard to get an accurate response here.

When the player types extremely common words like "you", "and", "me", etc, a reaction is triggered. Oh, I don't think the player would find this reasonable and fun.

And you misspelled some words in your texts (lines of Monica).

For example, "I with" should be "I wish", I guess.

Lastly, those lines are too straightforward in the term of emotion. In my mind, Monika is too intelligent to express her desire in such a way. Anyway, this is just my opinion. Very subjective.

multimokia commented 4 years ago

Nah, they're okay in his PR since it expects all of those keywords to be present. Not any single one of them

SonicEraZoR commented 4 years ago

I fixed the "with" typo though. As for the lines, well I don't know, I just written them how I would want to hear them from her when I was playing You and me and her. And yeah as multimokia said, it searches for all of the keywords, I even specifically tested this before creating pull request

grandsong commented 4 years ago

I see. But I'm afraid this is at the other end: the player will never trigger this reaction unless someone tells him to type such a long phrase (including a ":") extactly. Still, it is a good thing for you to add a reaction.

multimokia commented 4 years ago

It's in the window handle of the game though, which is what's intended

SonicEraZoR commented 4 years ago

Yeah, this reactions are meant for when you're playing the game

SonicEraZoR commented 4 years ago

Though, adding reactions for google searches and steam store page of you and me and her might be nice too. Or even add reactions for then you open page of 18+ patch for the game