Monkestation / Monkestation2.0

A monkestation rebase to TG code
https://monkestation.com/
GNU Affero General Public License v3.0
48 stars 247 forks source link

Megafauna ability cooldowns are broken #4286

Open tubifextubifex opened 5 days ago

tubifextubifex commented 5 days ago

Round ID:

7908

Testmerges:

This has been occurring for more than a year I just never got around to reporting it.

Reproduction:

It's most noticeable on Bubblegum when he goes below 50% HP, he starts chaining abilities together that are supposed to have a cooldown resulting in him charging at you for 40+ seconds straight. Other megafauna also suffer from this but to a much lesser degree, ash drakes in particular can cover the entire screen with fire even on low time dilation if they chain together the radial fire shooting attack.

As far as I can tell this was fixed by: https://github.com/tgstation/tgstation/pull/68382 https://github.com/tgstation/tgstation/pull/66373

https://github.com/tgstation/tgstation/pull/83694 fixes megafauna melee which is also bugged

Video showcasing the problem, worst example is at 2:10 although I've seen it get even worse than that before: https://youtu.be/_wZ56DzfztE?t=130

tubifextubifex commented 5 days ago

I thought it might be hard to see what the issue is if you don't play shaft miner so I made another video on /tg/ to try and help. If you look at https://youtu.be/_wZ56DzfztE?t=130 you can see Bubblegum is doing

  1. https://www.youtube.com/watch?v=3sRQRXwG_30&t=57s and
  2. https://www.youtube.com/watch?v=3sRQRXwG_30&t=9s simultaneously and then after doing one charge from attack 2 immediately moves into
  3. https://www.youtube.com/watch?v=3sRQRXwG_30&t=49s while simultaneously starting
  4. https://www.youtube.com/watch?v=3sRQRXwG_30&t=9s again and then doing 1 charge and immediately going into
  5. https://www.youtube.com/watch?v=3sRQRXwG_30&t=9s again followed by some more
  6. https://www.youtube.com/watch?v=3sRQRXwG_30&t=49s and then stops. He should be behaving like in https://www.youtube.com/watch?v=3sRQRXwG_30&t=49s, https://www.youtube.com/watch?v=3sRQRXwG_30&t=9s, and https://www.youtube.com/watch?v=3sRQRXwG_30&t=57s performing only 1 of these attacks and then stopping for a few seconds.