MonkeyModdingTroop / MonkeyLoader

A convenience and extendability focused mod loader using NuGet packages.
https://monkeymoddingtroop.github.io/MonkeyLoader/index.html
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Disallow loading into worlds tagged "nomods" #51

Open 3x1t-5tyl3 opened 2 days ago

3x1t-5tyl3 commented 2 days ago

Basically boils down to: I don't use mods. Others do They're improperly coded and cause me to crash. I'd like to tag my hosted session to either disallow the loading of mods or joining.

Or both with a setting. (ergo differrent tags -> nomodsload, nomodsjoin)

Or some way for me as a vanilla user to not crash due to an imporper mod's configuration, coding or otherwise.

Edit: To be clear it is not my responsibility as a vanilla user to make sure modded users cause me to crash or to find the bugs associated with that. It is strictly on the mods and the modloader to make sure this doesn't happen.

Same issue on RML: https://github.com/resonite-modding-group/ResoniteModLoader/issues/18

Nytra commented 1 day ago

Mods don't really crash other people, unless you have an example of one that does

Banane9 commented 1 day ago

Technically not the repository concerning Resonite, but it can't be transferred to the right one, so I'll let it stand here :'D

My initial reaction would be to say that I've not witnessed anyone crashing because of not having a certain mod. Either way, the... not yet available mod policy for Resonite would likely say that mods must not affect others negatively, so users joining your sessions and (intentionally) crashing you with badly made mods would be in violation of that regardless.

Nytra commented 1 day ago

Regardless, crashing is basically a common thing in Resonite that can be caused even without mods

Banane9 commented 1 day ago

Either way, mods can't be prevented from loading for a world, as that's all done at startup. A mod (or part of it) can be deactivated at runtime as a global action, but it has to explicitly support that.

Likewise, mod authors would be responsible for respecting a "no modded content in this session" tag - all we can do is add an easy way for mod authors to check if a given session has that tag or not.

We also wouldn't wholly prevent mod users from joining tagged sessions, as they may only be using local mods, or rely on them for accessibility for example. We could, however, look into displaying a warning / confirmation to join such a session.

3x1t-5tyl3 commented 1 day ago

Regardless, crashing is basically a common thing in Resonite that can be caused even without mods

Nytra. No. This is asanine reasoning and I won't even bother argueing. Just because "we already crash a lot". Does not mean modded users should just be allowed to crash me with their world-modifying mods that change my vanilla behaviour.

Technically not the repository concerning Resonite, but it can't be transferred to the right one, so I'll let it stand here :'D

My initial reaction would be to say that I've not witnessed anyone crashing because of not having a certain mod. Either way, the... not yet available mod policy for Resonite would likely say that mods must not affect others negatively, so users joining your sessions and (intentionally) crashing you with badly made mods would be in violation of that regardless.

I don't know which is which. I don't use mods. I targeted the main two ones I could find. So apologies there.

I'm not sure which mods cause it. I want to strongly reiterate that mods crashing me is not my problem to deal with.

I am a vanilla user. It should be respected by the mods and me not wanting an extra cause of crashing while I'm doing things is reasonable.

Banane9 commented 1 day ago

I'm not sure which mods cause it. I want to strongly reiterate that mods crashing me is not my problem to deal with.

Thing is, we're not aware of any mods that would be known for crashing others. Personally, all my mods definitely shouldn't - and if that was somehow the case, I'd definitely want to know about it.

I am a vanilla user. It should be respected by the mods and me not wanting an extra cause of crashing while I'm doing things is reasonable.

It's in your rights to self-moderation to exclude any mod users from your sessions. However, as described, it isn't our responsibility to absolutely prevent users from joining them. You wouldn't expect Resonite to be responsible for preventing users with a Rexouium avatar (or whichever) from joining your sessions either, for example.

What we could do is give mod authors a tool to respect this wish and a warning for users when joining such sessions.