search

MonoOni / binarydist

Mono Binary Builds for Testing
9 stars 0 forks source link

Make #ifdefs only relevant to i controlled by a flag #15

Closed NattyNarwhal closed 6 years ago

NattyNarwhal commented 6 years ago

This would clarify intent for what's needed for i vs. AIX; and lets us build a marginally better build for AIX.

This would likely consist of considering _AIX defines to say, __PASE__. Because i tooling is the same as AIX and thus won't have a flag; and since we cross-compile from AIX anyway, we'd have to pass a flag manually - but adding -D__PASE__ to ./configure is no problem.

kadler commented 6 years ago

FYI, the GCC compilers that we ship with yum define __PASE__ automatically

NattyNarwhal commented 6 years ago

Ah, I'll have to switch definitions over to that - when I was doing the initial bringup on i, Perzl and Bull's toolchains didn't define that (being for AIX) and I wasn't aware of the new IBM toolchain.

kadler commented 6 years ago

Right. We're still shipping a modified & repackaged AIX toolbox GCC version, but we modified the GCC specs file to add -D__PASE__. You could so yourself as well. gcc --dumpspecs > specs, modify specs, move it next to libgcc_s.a under /opt/freeware/lib/gcc/... Or just define it in the CPPFLAGS passed to configure.

NattyNarwhal commented 6 years ago

Upstream merged said changes; so fixed.