Open TheDuckCow opened 5 years ago
In reviewing this, there seem to be additional bugs at the moment where there are multiple imports of the MCprep control object for some reason. I noticed this in blender 3.2 and 3.0 and only when using the option to add physical sun and moon; there are two that are generated when using "Static sky + mesh sun/moon".
Likely the root issue is that importing the sun/moon mesh automatically brings in dependencies, so we would need to save the source file with certain constraints or parents already removed for it to work properly.
Nobody has really cited this as an issue, and requires some refectoring. I'm going to push this some more.
I'm going to remove this from a milestone. I haven't actually heard anyone complaining about this. Good to have, but not a high priority. Still a good first contribution though.
Right now, there is not good support for having multiple scenes in the same blender file all using their own separate copies of the Dynamic world system. It appears broken if trying to add a new dynamic world into a second scene.
Modify the code to support this, ensuring that searching for objects with the time control property are local to the active scene only. Consider canonically registering the object name to the scene as a fallback to choose between conflicts if multiple objects somehow end up in the same scene and both have the time control property.