Feat/authorship - Githubissues

MoonSHRD / UniversalNFTMarketplace

Universal NFT Marketplace

Other

9 stars 0 forks source link

Feat/authorship #103

Closed JackBekket closed 2 years ago

JackBekket commented 2 years ago

Add function to Update Authorship for Unique token type (пока что в виде уродливого костыля)
Add function to Royalties calculation (work only for MSNFT type)
Implement Royalties into payment mechanisms
Changed service fee to 1.5% (+1.5% royalties if appliciable)

todo[bot] commented 2 years ago

should be changed visibility to external?

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/51c151142ffb38b130449e99252c3b6c27554e21/contracts/721/singleton/MSNFT.sol#L156-L159

This comment was generated by todo based on a `todo` comment in 51c151142ffb38b130449e99252c3b6c27554e21 in #103. cc @MoonSHRD.

todo[bot] commented 2 years ago

check calculation in tests

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/51c151142ffb38b130449e99252c3b6c27554e21/contracts/721/singleton/MetaMarketplace.sol#L428-L433

This comment was generated by todo based on a `todo` comment in 51c151142ffb38b130449e99252c3b6c27554e21 in #103. cc @MoonSHRD.

todo[bot] commented 2 years ago

delete the function below before release

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/51c151142ffb38b130449e99252c3b6c27554e21/contracts/test_erc20_tokens/MST.sol#L11-L14

This comment was generated by todo based on a `TODO` comment in 51c151142ffb38b130449e99252c3b6c27554e21 in #103. cc @MoonSHRD.