search

More-Wrong / Factorio-True-Nukes

A factorio mod adding realistic nuclear blasts, and more nuclear options.
MIT License
3 stars 8 forks source link

Added feature: Crater fills with water if it forms next to water #2

Closed mandelbrodt closed 3 years ago

mandelbrodt commented 3 years ago

I changed the formation of nuke craters next to water to be more natural. A nuke crater that forms touching 'water' or 'deepwater' tiles is now formed filled with 'water' tiles. Added a check so that crater noise doesn't replace 'water' or 'deepwater' tiles with 'nuclear-ground' tiles.

Love the mod, though I thought it was a bit unrealistic how an explosion next to or over water upheaves the ocean floor to create the crater. factorio_2021_03_20_20_12_33_981

More-Wrong commented 3 years ago

Hi, Thanks for the pull request - I hadn't really thought about how unnatural the craters are when interacting with water (and terrain in general), so this is an excellent suggestion. I am currently rather busy, so will be able to look in more detail next weekend. Just a few points about the changes: They need to interact well with the larger nukes (e.g. 100kt and 1Mt) as these nukes would reasonably vaporise Factorio - sized lakes. It might be worth adding some kind of check for the larger nukes to ignore bodies of water and go with the old crater system. There might also be a problem with larger nukes (>500t) as to how they interact if fired close to the middle of a lake - they could change some areas around the outside of the lake into crater without any trace on the inside.

This might end up bundled with a few other aesthetic changes I have been thinking about (adding decoratives more in-keeping with the destruction in the fireball, and removing grass in the fireball).

mandelbrodt commented 3 years ago

Thanks for the reply!

as these nukes would reasonably vaporise Factorio - sized lakes [...] they could change some areas around the outside of the lake into crater without any trace on the inside.

Good points. I've made some changes to hopefully address what you meant:

factorio_2021_03_21_16_11_51_441 factorio_2021_03_21_16_15_09_257

I guess for more realism, you could also look the size of a body of water that touches the crater edge to determine if the crater forms with water.

They need to interact well with the larger nukes (e.g. 100kt and 1Mt)

At max, my PC can only 'reliably' handle the 15kT nuke, so I'll leave testing of the larger nukes to you...

This might end up bundled with a few other aesthetic changes I have been thinking about

Sounds great, looking forward to more features in this awesome mod! Feel free to close this pull request whenever.