MoreMcmeta / emissive-plugin

Plugin for MoreMcmeta to enable emissive textures for blocks, items, entities, and block entities.
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Redstone z-fighting #4

Closed 7777777-4547 closed 1 year ago

7777777-4547 commented 1 year ago

Describe the bug Some emissive UV Face obstruct emissive others. Redstone dust have Z-fighting.

To reproduce Steps to reproduce the behavior:

  1. Install Glowing Resourcepack
  2. Join a world and make a dark environment
  3. Place redstone torch and redstone dust
  4. See error

Expected behavior Redstone torch has some Alpha UV face to obstruct other emissive thing's emissive face. Redstone dust will have Z-fighting.

Screenshots or videos 2023-08-25_03 07 17 2023-08-25_03 07 32 GIF 2023-8-25 3-09-28

Which Minecraft versions does this bug affect? 1.16.5

Mod loader Which mod loaders does this bug affect?

Mods list

Resource pack

Additional context None

soir20 commented 1 year ago

Thanks for the detailed report and images. I am going to split this into two threads because these are two separate issues. This will become the tracking issue for the z-fighting problem with redstone dust. #5 will become the tracking issue for the face obstruction issue.

soir20 commented 1 year ago

Emissive plugin v1.1.1 has been released. This version contains a z-fighting fix pack with a custom block model that avoids the z-fighting issues. You'll need to enable this from your resource packs screen.

A special block model has to be used because Minecraft rendering has issues with a bunch of translucent quads on top of each other like in the redstone model. If you look very closely, you'll notice that two pixels aren't visible in the new model that are visible in the old one; enlarging the model to include these two pixels causes a small rendering bug. It's not that noticeable, though. (The programmatic alternatives I tested didn't work well.)

Please report any other instances of z-fighting that you notice; these unfortunately have to be fixed individually. However, the redstone model seems fairly unique, so this is hopefully the only instance of the problem.

soir20 commented 1 year ago

Version 2.0.0 has been released, which should fix this issue (without the need for the z-fighting fix pack). It will take a few minutes for the files to be approved on CurseForge. Please let me know if you encounter any issues in the new version.