MoreMcmeta / emissive-plugin

Plugin for MoreMcmeta to enable emissive textures for blocks, items, entities, and block entities.
GNU Lesser General Public License v3.0
4 stars 0 forks source link

Item Enchantment Glint and Item Entities Removing Rendering of Some Objects #7

Closed RosiePies closed 1 year ago

RosiePies commented 1 year ago

Describe the bug Enchanted items have the whole texture face glinted. Item entities' UV faces remove the rendering of water, item frames, and tile entities.

To reproduce Steps to reproduce the behavior:

  1. Join any world.
  2. Place water, an item frame, or a tile entity.
  3. Throw an item (enchanted or not) on the ground in front of any object referenced in 2.
  4. See error

Expected behavior Items' enchantment glint applies to opaque/translucent pixels of an item only. Item entities do not obstruct rendering of water, item frames, or tile entities.

Screenshots or videos 2023-10-03_02 52 26 2023-10-03_02 59 10 2023-10-03_02 59 23

Which Minecraft versions does this bug affect? 1.20.1

Mod loader Which mod loaders does this bug affect?

Mods list emissive-plugin-1.20.1-1.1.1-forge moremcmeta-1.20.1-4.2.4-forge

Resource pack None

soir20 commented 1 year ago

MoreMcmeta uses translucent (partially transparent) emissive overlays. I believe this is an issue with vanilla Minecraft rendering when item models have translucent faces. You can cause this issue to happen in vanilla Minecraft by throwing stained glass panes on the ground near water. I will take a closer look to ensure that is the case.

I have noticed that this issue does not happen on Fabric, if you are able to use that instead of Forge.

I have some early plans for a v2 of this mod where overlays will not support translucence by default, but you can enable it on a per-overlay basis. That would help with a lot of these issues related to the translucent rendering, since almost all existing emissive packs don't need partial transparency. I don't have an ETA on that as it's still in a planning phase. The vast majority of issues reported have been translucence-related, so I'll likely create a separate tracking issue for this until v2 is released.

soir20 commented 1 year ago

I've found the cause of the issue; it seems like the easiest way to fix this is likely to work on the v2 update. v2 looks to be simpler to implement than I expected, so hopefully this issue and other issues will all be resolved.

soir20 commented 1 year ago

I have a working 2.x development version that fixes this issue. I am hoping for a release this weekend if no issues are discovered while I do more thorough testing.

soir20 commented 1 year ago

Version 2.0.0 has been released, which should fix this issue. It will take a few minutes for the files to be approved on CurseForge. Please let me know if you encounter any issues in the new version.