Open thesudoer2 opened 2 months ago
@thesudoer2 Thanks a lot for this evaluable suggestions All your PRs regarding these improvements are appreciated.
@MortezaBashsiz My pleasure :) I will work on "Maintainability - 1" and "General - 1" sub-issues until further notice.
Hello there, I have some recommendation that can enhance maintainability, and performance and generally improve overall project quality.
Maintainability
Performance
std::make_shared
instead ofnew
for keep shared pointer control block and object block in contiguous memory blocks (better performance).General
#ifndef/#define
and#pragma once
as include guards is redundant.#ifndef/#define
can be removed, and only#pragma once
can be used because almost all modern C++ compilers support it.