search

MotherTongues / mothertongues-UI

1 stars 2 forks source link

New web UI based on Talking Michif Dictionary #4

Closed dhdaines closed 5 months ago

dhdaines commented 7 months ago

This is minimally ready for review! There are a couple of little bugs still and the layout could be tweaked further.

github-actions[bot] commented 7 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://MotherTongues.github.io/mothertongues-UI/pr-preview/pr-4/ on branch gh-pages at 2024-04-23 16:40 UTC

dhdaines commented 6 months ago

The deploy-preview URL doesn't seem to actually work ... I don't understand how to make it work so I'll let you deal with that :)

dhdaines commented 5 months ago

Hey @dhdaines - this is awesome, thanks so much! I've made a few small changes in #7 and #8 that I would like to merge first (rebase merge #8 onto #7 first if you do it through GitHub). There are a lot of commits here, so once we merge #7 and #8, I think we should squash merge this into main.

Yes, squashing would be a good idea! I'll see if I can make the fix to the sampling I mentioned in #7 but it seems like I should probably merge both of them first to avoid formatting issues.

dhdaines commented 5 months ago

I think this is okay to merge now, though we can still improve it in a separate PR, it works well.