Mouse-Imaging-Centre / RMINC

Statistics for MINC volumes: A library to integrate voxel-based statistics for MINC volumes into the R environment. Supports getting and writing of MINC volumes, running voxel-wise linear models, correlations, etc.; correcting for multiple comparisons using the False Discovery Rate, and more. With contributions from Jason Lerch, Chris Hammill, Jim Nikelski and Matthijs van Eede. Some additional information can be found here:
https://mouse-imaging-centre.github.io/RMINC
Other
23 stars 17 forks source link

anatLmer reinit fails #261

Closed cfhammill closed 4 years ago

cfhammill commented 5 years ago

Looks like the formula object is getting out of scope. I think this can be fixed at

https://github.com/Mouse-Imaging-Centre/RMINC/blob/master/R/minc_lmer.R#L357

by setting form to lmod$formula instead of the version in mcout. The default optimizer changed in the recent lme4 release which seems to make the fit more sensitive when evaluating convergence.

cfhammill commented 4 years ago

Haven't seen this in develop since the fix, closing for now.