search

MovingBlocks / TeraNUI

Terasology's New User Interface
https://terasology.org/TeraNUI/
Apache License 2.0
4 stars 10 forks source link

fix(ModuleTypeRegistry): don't skip merging reflections when possible #52

Closed keturn closed 3 years ago

keturn commented 3 years ago

Modules made with createPackageModule can have reflections without knowing what their classpaths are.

I think this change is sufficient to make Terasology's "engine module" work in https://github.com/MovingBlocks/Terasology/pull/4622

keturn commented 3 years ago

Not sure what to say about a test plan for this. Because I don't think there are any users of nui-gestalt7 right now, other than the Terasology branch.

Arguably there should be a unit test for it? but it's so much to do with the details of modules and Reflections, and I am reluctant to spend time on Reflections-related things when Reflections is on the chopping block.

jdrueckert commented 3 years ago

[GESTALTv7] migrate module & asset