add _layouts and _includes folder

MozillaIndia / blog

Replacement for the wordpress engine at blog.mozillaindia.org

https://mozillaindia.github.io/blog/

Mozilla Public License 2.0

1 stars 14 forks source link

add _layouts and _includes folder #22

Closed srishti-nema closed 5 years ago

srishti-nema commented 5 years ago

Description

Changes proposed in this pull request: I have added a copy of the following files :

_includes/footer.html
_includes/header.html
_includes/social.html
_layouts/default.html
_layouts/home.html
_layouts/page.html
_layouts/post.html
_includes/head.html
_sass/minima.scss
_sass/minima/_base.scss
_sass/minima/_layout.scss
_sass/minima/_syntax-highlighting.scss
css/style.scss

Related Issues and PRs

This is a reference to #2 and #19. Would allow development of #7 , #8 , #9 .

karx commented 5 years ago

@srishti-nema Can we make the Description of this issue a bit more descriptive.

Also I would suggest removing author.yml as it is being already addressed as a separate issue #14 with a linked PR #20.

If I were in your shoes, I would have framed it as follows:

Description

As discussed in #2 and aimed in #19. This PR basically creates a copy of the following files we need in our local Jekyll repository.

_includes/footer.html
_includes/header.html
_includes/social.html
_layouts/default.html
_layouts/home.html
_layouts/page.html
_layouts/post.html

Related Issues and PRs

This is reference to #2 and #19. Would allow rapid development for #7 #8 #9

Screenshots

Also add images, for all pages - with changes in HTML or CSS atleast

asdofindia commented 5 years ago

Two more tasks before this can be merged:

rebase onto master to avoid the authors commit
some files are missing like "head.html" which is referred to in default.html

srishti-nema commented 5 years ago

Two more tasks before this can be merged:

* rebase onto master to avoid the authors commit

* some files are missing like "head.html" which is referred to in default.html

There are CSS files linked inside the head.html file, for which some other Sass files need to be added. Should I add all of them for now, or is there any other way?

asdofindia commented 5 years ago

Adding everything would be the right thing to do. Otherwise the theme is half here and half there

asdofindia commented 5 years ago

I think this will do. But, can you do a rebase on the current master to avoid the unnecessary commits? You can update your master and then do a git rebase -i master from your feature2 branch and interactively choose only the commits you wanted in this PR (while also squashing some of them)

asdofindia commented 5 years ago

I think there will still be some broken references (for example, to the assets folder), but let me merge this first and we can take care of those later. Thank you so much for the persistence. 🧡