Mr-X-GTA / YimMenu

YimMenu, a GTA V menu protecting against a wide ranges of the public crashes and improving the overall experience.
https://yim.gta.menu
GNU General Public License v2.0
81 stars 23 forks source link

Fix: Join Public Session | Auto kick Host to become Host #32

Closed SourceModzZ closed 3 weeks ago

SourceModzZ commented 3 weeks ago

Here is a revision of the code. It is now clean and tidy without any major changes to the source.

divinusinc commented 3 weeks ago

and what exactly does this fix if forcing host is no longer a thing, pretty much kicking the host for no reason

SourceModzZ commented 3 weeks ago

and what exactly does this fix if forcing host is no longer a thing, pretty much kicking the host for no reason

Doesn't that really matter? The main thing is that there is the possibility to join a public lobby. Some people in the YimMenu fork of MrX had wished, So I implemented it like this.

Deadlineem commented 3 weeks ago

and what exactly does this fix if forcing host is no longer a thing, pretty much kicking the host for no reason

It automatically kicks the host so you can get host priority. It does not spoof host but if you set the session spoofing to off and auto kick host on repeat, it will give you host eventually. Usually within 3-5 kicks of the host. Unsure if the code was added but it should also refrain from trying to kick other modders (if they are detected by YimMenu) too making it safe to deflect an accidental kick and should just let you join in.

xiortgav commented 3 weeks ago

and what exactly does this fix if forcing host is no longer a thing, pretty much kicking the host for no reason

It automatically kicks the host so you can get host priority. It does not spoof host but if you set the session spoofing to off and auto kick host on repeat, it will give you host eventually. Usually within 3-5 kicks of the host. Unsure if the code was added but it should also refrain from trying to kick other modders (if they are detected by YimMenu) too making it safe to deflect an accidental kick and should just let you join in.

Maybe you will have to kick the whole session just to get the host?

SourceModzZ commented 3 weeks ago

and what exactly does this fix if forcing host is no longer a thing, pretty much kicking the host for no reason

It automatically kicks the host so you can get host priority. It does not spoof host but if you set the session spoofing to off and auto kick host on repeat, it will give you host eventually. Usually within 3-5 kicks of the host. Unsure if the code was added but it should also refrain from trying to kick other modders (if they are detected by YimMenu) too making it safe to deflect an accidental kick and should just let you join in.

Maybe you will have to kick the whole session just to get the host?

Even if that happens, you just change the session. I tried it again yesterday and so far I haven't had a single case where I kicked the whole session.But I can see that people actually mean well. I will just close the pull request then.

Pochemy-ux commented 3 weeks ago

и что именно это исправит, если принудительное удаление хоста больше не является чем-то, по сути, это просто удаление хоста без причины

Он автоматически выкидывает хоста, чтобы вы могли получить приоритет хоста. Он не подделывает хост, но если вы отключите подмену сеанса и автоматически выкидывать хоста при повторе, он в конечном итоге даст вам хост. Обычно в течение 3-5 выкинов хоста. Не уверен, был ли добавлен код, но он также должен воздержаться от попыток выкинуть других моддеров (если они обнаружены YimMenu), что делает безопасным отклонение случайного выкида и должен просто позволить вам присоединиться.

Может быть, вам придется прервать всю сессию, чтобы просто получить доступ к хосту?

Даже если это произойдет, вы просто измените сессию. Я попробовал еще раз вчера, и пока у меня не было ни одного случая, чтобы я выгнал всю сессию. Но я вижу, что люди на самом деле имеют добрые намерения. Тогда я просто закрою запрос на вытягивание.

before becoming a host in a session there are 10 people left and no more come in even if you start advertising because for some reason the session advertising doesn’t work. Is there any way to fix this?

Mr-X-GTA commented 3 weeks ago

Can you test https://github.com/Mr-X-GTA/YimMenu/pull/33?

SourceModzZ commented 3 weeks ago

Can you test #33?

Amazing Work. Works great. I will close my Pull Request. Yours is better.