search

MrPrimate / pathmuncher

Munch Pathfinder 2e characters into Foundry from Pathbuilder
MIT License
23 stars 6 forks source link

wrong saving throws structure #32

Closed intrand closed 9 months ago

intrand commented 9 months ago

https://github.com/MrPrimate/pathmuncher/blob/main/src/app/Pathmuncher.js#L1312-L1314

  #setSaves() {
    setProperty(this.result.character, "system.saves.fortitude.tank", this.source.proficiencies.fortitude / 2);
    setProperty(this.result.character, "system.saves.reflex.value", this.source.proficiencies.reflex / 2);
    setProperty(this.result.character, "system.saves.will.value", this.source.proficiencies.will / 2);
  }

in pf2e system 5.9.5 should be

  #setSaves() {
    setProperty(this.result.character, "system.savingThrows.fortitude", this.source.proficiencies.fortitude / 2);
    setProperty(this.result.character, "system.savingThrows.reflex", this.source.proficiencies.reflex / 2);
    setProperty(this.result.character, "system.savingThrows.will", this.source.proficiencies.will / 2);
  }

I'd submit a PR, but I have no idea what else might need to change and I don't really use pathmuncher anymore. This was found by inspecting a foundry export of a character that was imported a long time ago.

MrPrimate commented 9 months ago

Resolved in v0.11.4, thankyou for the heads up.