[Bug]: Path issues | Failed conversions to .ogg | URL write issues.

LyraKeaton commented 2 months ago

General Info

[X] I am running a modpack
[ ] I can reproduce this issue consistently in single-player
[X] I can reproduce this issue consistently in multi-player
[X] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
[ ] I am crashing and can provide my crash report(s)
[X] I am using the latest version of the mod

Forge version

47.3.0

Minecraft version

1.20.1

Mod version

1.0.0

Java version

GraalVM Java 21.0.4.0

Issue Description

Initially couldn't get FFMPEG to convert the .webm correctly. Realized that it first looks for your path, not what's in the directory. I had a botched install of FFMPEG and it wouldn't convert until I fixed my path related issues. Would be better for modpack authors if it first checked the directory instead.

Additionally, after reinstalling ffmpeg (it is now fixed in my path and present in the config\disccord\ffmpeg folder), ffmpeg only converts the file to .raw. The log then reads:

[15:42:28] [Worker-Main-1/ERROR] [co.mr.di.DiscCordMod/]: Failed to load audio stream java.io.FileNotFoundException: H:\MultiMC\instances\Wizards & Wardens.minecraft\config\disccord\client_downloads\9cab08a3ac95168d833817f21311fda0f6f9d8c7d4c7baca626a58b626a00b86.ogg (The system cannot find the file specified)

After studying your code, I believe the issue could potentially lie with asynchronous conversion to .ogg. I converted the .raw file myself using the exact same arguments as the executeFFmpegCommand function call, and the music disk then correctly played in-game.

Lastly, once I have written a URL on a disk and played it in the jukebox, I am unable to change the URL on the disc, or write a new URL for any further disks I make. I then have to disconnect from the server and reconnect, after which I can now write a new URL. This bug happens consistently after a while, but isn't reproducible each time. Sometimes it'll let me edit, sometimes not.

Additional Information

No response

Mrbysco commented 4 weeks ago

This has likely been fixed in a recent update on 1.21.1 and will likely be backported

Mrbysco commented 3 weeks ago

A new version has been released for 1.20.1 and 1.19.2. Please check if the issue persists

Mrbysco / DiscCord