search

Mte90 / facebook-direct-links

Say bye to redirect on Facebook with this very simple extension!
GNU General Public License v3.0
16 stars 7 forks source link

Clean up URLs from tracking #36

Open Mte90 opened 3 years ago

Mte90 commented 3 years ago

On this list https://github.com/mpchadwick/tracking-query-params-registry/blob/master/_data/params.csv there are a lot parameters that we can strip. I don't know if it is the case to generate a json from that or pick just the most useful one, what do you think @PeterDaveHello?

PeterDaveHello commented 3 years ago

This reminds me that there are also: https://github.com/Cimbali/CleanLinks/issues/63 and https://github.com/AdguardTeam/FiltersRegistry can be referenced, and currently the tracking clean up function here is not very maintainable(no offense), could refactor the code first and look for a better way to maintain the filter list.

As https://github.com/mpchadwick/tracking-query-params-registry/blob/master/_data/params.csv is csv format, is easy to convert it into a json format that js can easily consume, my idea is that we can use some external filter list like it, and then only maintain those not existed in all external filter list(before out pull requests to those repository are accepted, or for those not acceptable, if there are some) in this project.

Mte90 commented 3 years ago

function here is not very maintainable(no offense)

Of course it isn't I am not a good javascript developer :-)

only maintain those not existed in all external filter list

Seems a good idea