search

MuckRock / muckrock

MuckRock's source code - Please report bugs, issues and feature requests to info@muckrock.com
https://www.muckrock.com
GNU Affero General Public License v3.0
114 stars 22 forks source link

Request recover tool crashes #918

Open morisy opened 8 years ago

morisy commented 8 years ago

Looks like the request recovery tool doesn't actually work, instead just crashing

https://www.muckrock.com/admin/foia/foiarequest/recover/

mitchelljkotler commented 8 years ago

https://github.com/etianen/django-reversion/issues/368

Its just slow. We keep 6 months of FOIA requests for reversion right now, do we want to try lowering that? Not sure how low we need to go to get it to work.

mitchelljkotler commented 8 years ago

I deleted down to 3 months on staging and that page then loaded very quickly, for reference

morisy commented 8 years ago

Ok, that's fine but before we do that I'd like to discuss backups. I thought we had an open issue for them but can't find it.

Creating a new issue for that; and once that's resolved we can take a peak at this again (right now non-urgent).

mitchelljkotler commented 8 years ago

Also, I believe requests actually being delete should be fairly rare? Drafts may be deleted, but once a request is submitted it should only be deleted in extenuating circumstances, correct? The great request remodeling may help here, as drafts will be a separate model.

morisy commented 8 years ago

Yeah, it's pretty rare/done by admins, and when it does happen accidentally we should be pretty aware of it almost immediately