MultiChain / multichain

Source code for multichaind, multichain-cli and multichain-util.
GNU General Public License v3.0
536 stars 259 forks source link

Missing error message details on non-mandatory-script-verify-flag #94

Open timmclean opened 5 years ago

timmclean commented 5 years ago

When sendrawtransaction is used with a transaction signature not in canonical form, the following error is returned:

16: ConnectInputs failed: non-mandatory-script-verify-flag (No error)

(No error) should be the actual error message, but it looks like error message is being taken from the wrong CScriptCheck instance:

https://github.com/MultiChain/multichain/blob/4ddb443cc5ec4522b540b8e034c083c8d159de25/src/core/main.cpp#L2147-L2150

check is the instance that succeeded, so it is always "No error". The error message from the check that failed should be used instead.

gidgreen commented 5 years ago

Thanks, we'll take a look.