search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.32k stars 883 forks source link

[Suggestion] Auth Fix for pre-Beta 1.8 using Proxy #2945

Open VivianTheFox opened 4 years ago

VivianTheFox commented 4 years ago

Up until Beta 1.8, the URL that Minecraft used to check the auth system was https://login.minecraft.net/session?name=, which was replaced later with http://session.minecraft.net/game/joinserver.jsp?user= As of now, this old URL is dead and goes nowhere. My suggestion is to add an internal proxy to MultiMC to redirect this old URL to the modern and functioning one.

The idea for a solution is taken from another launcher, Glass Launcher, which accomplished the task of patching this issue by setting up a proxy to replace the requests from the old URL with the new one https://github.com/ModificationStation/Glass-Launcher-Legacy/tree/master/src/main/java/net/glasslauncher/proxy

I wouldn't recommend using the same code obviously, especially as it's coded in Java, but the concept is I good one I feel. It'd be helpful to have a working solution bundled into the launcher for these older versions, automating the process of fixing it rather than telling people they need to plug in their own proxies into the launcher.

The main benefit of this would be added security for the older versions, as most of the time because of the lack of a working auth system most servers just go without the Mojang auth and just use AuthMe. AuthMe works fine for preventing some issues, but as all old plugins it has holes in it and you can still flood servers with alts because there's no check the server has to see whether or not the people joining are real or not.

Yes, the same thing could be accomplished just by telling people to use their own proxy solutions. There is no need to add this to MultiMC. However, automating the process makes it so not every single person needs to be told to fiddle with launchers they might not understand all that well to fix an issue that they barely understand. It's a nice thing to include for the average user, as it's one less thing they need to worry about when trying to play these older versions of the game.

Overall, it's something that'd probably be fairly trivial to add to MultiMC and it would be nice to the communities who still work with these versions on a daily basis.

Johnanater commented 4 years ago

+1 Would be an awesome feature.

alexyao2015 commented 4 years ago

This would probably difficult/impossible to do since the old url uses https which by design prevents forging like this.