MultiSafepay / magento2-core

Provides core functionalities
Open Software License 3.0
2 stars 10 forks source link

Fix notices when no postcode is present on the address #8

Closed thlassche closed 2 years ago

thlassche commented 3 years ago

Some shops do not make postal codes required, this leads to a problem when checking out because calling trim() on NULL yields a notice in PHP

vinodsowdagar commented 3 years ago

Hi @thlassche ,

Thank you for the PR, we are currently looking in to reproducing and reviewing this. Once i know more i will let you know.

vinodsowdagar commented 2 years ago

Hi @thlassche ,

I am closing your PR as we have already internally reviewed and merged it. It is available in the latest release: https://github.com/MultiSafepay/magento2/releases/tag/2.13.0

As a thank you for your contribution we would like to send you a t-shirt designed by MultiSafepay. If you are interested, could you send us your shirt size and address at integration@multisafepay.com?