search

Multiverse / Multiverse-Core

The original Bukkit Multi-World Plugin!
BSD 3-Clause "New" or "Revised" License
960 stars 298 forks source link

[Idea]: Folia support for Multiverse-Core #2901

Open Agaloth opened 1 year ago

Agaloth commented 1 year ago

Describe the feature

https://github.com/PaperMC/Folia

Here is a summary of everything made with ChatGPT to save some time:

For plugin developers, there are a few key takeaways from the given text:

  1. Folia introduces regionised multithreading, which means that plugins will require modification to function properly. Plugin developers should expect compatibility with existing plugins to be at zero.

  2. Folia introduces new API additions, such as the RegionisedScheduler and EntityScheduler, which can help plugins run on the correct thread context.

  3. To ensure compatibility with Folia, plugin developers must mark their plugin as compatible by placing "folia-supported: true" in the plugin.yml file. Additionally, plugins must take advantage of the RegionisedScheduler and EntityScheduler API to ensure correct behavior.

  4. Plugins should not assume that they can access or modify data in other regions, as Folia regions tick in parallel and do not share data. Plugin developers should take advantage of the upcoming thread-check API to ensure correct behavior.

  5. There are currently broken API, including the scoreboard API, and planned API changes, such as super aggressive thread checks, which may impact plugin development.

Overall, plugin developers should be prepared for significant changes in their plugins to ensure compatibility with Folia. They should take advantage of the new API additions and mark their plugin as compatible to ensure correct behavior. Additionally, they should be aware of the limitations and rules of Folia's regionised multithreading to avoid bugs and errors in their plugins.

How is the feature useful to all Multiverse users?

This will be really useful to server owners, as Folia is a game changer but most plugins don't support it yet since it just came out.

Agreements

benwoo1110 commented 1 year ago

I have taken a look at Folia, it looks amazing and promising, but its API is not stable enough for MV to add support. Fundamentally, world loading/unloading functions are still marked broken as of now.

Aitooor commented 1 year ago

I have taken a look at Folia, it looks amazing and promising, but its API is not stable enough for MV to add support. Fundamentally, world loading/unloading functions are still marked broken as of now.

In the end, will it be possible to add support?

zax71 commented 1 year ago

It depends if Foila adds world loading support. Then we could support it

Aitooor commented 1 year ago

world loading support

I think they are implementing it now from what I see here https://github.com/PaperMC/Folia/pull/63

zax71 commented 1 year ago

world loading support

I think they are implementing it now from what I see here PaperMC/Folia#63

Yea it looks like they merged the method into the main

Just a draft for now, it isn’t merged yet

HarvelsX commented 1 year ago

Oh, the plugin seems to rely on processing in the main thread, which makes adapting it for Folia a difficult task.

LKD-PIX commented 7 months ago

Are there plans or Updates on this ?

zax71 commented 7 months ago

The PR was closed so I can’t see this happening any time soon

S0ly commented 2 months ago

reopen the PR please

NeverGrowUp commented 2 months ago

reopen the PR please

This was waiting on a paper PR, which got closed. There has been no PR for MV. This was purely an "idea"