Munich-Quantum-Software-Stack / QDMI

Quantum Device Management Interface (QDMI)
https://munich-quantum-software-stack.github.io/QDMI/
Apache License 2.0
26 stars 0 forks source link

Provision to set session parameters #100

Closed mnfarooqi closed 2 weeks ago

mnfarooqi commented 2 weeks ago

Closes #96

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #100     +/-   ##
=========================================
+ Coverage     86.0%   86.6%   +0.5%     
=========================================
  Files            7       7             
  Lines          798     815     +17     
  Branches       201     204      +3     
=========================================
+ Hits           687     706     +19     
+ Misses         111     109      -2     
Flag Coverage Δ
cpp 86.6% <100.0%> (+0.5%) :arrow_up:
Files with missing lines Coverage Δ
examples/driver/qdmi_example_driver.cpp 83.6% <100.0%> (+3.8%) :arrow_up:
mnfarooqi commented 2 weeks ago

This is really great! Thanks for the PR 🙏🏼 I have no comments on the actual additions in the PR. They look very clean. I have one request though: could we add a default implementation of the new function to the example driver? The session struct could just add a owner and token string member and use the new function to set them. Based on that example implementation, a test could be added for actually using the new method to set these parameters.

Already implemented will push it in the next commit.

I am not quite sure how far we want to take this in the examples, but I could imagine it would be useful if the new session information were actually to be used in the get_devices method for selecting which devices to return so that the new values are not only set, but also used in the examples. Let me know if you think that is taking it too far for now.

Working on it too.

burgholzer commented 2 weeks ago

This is really great! Thanks for the PR 🙏🏼 I have no comments on the actual additions in the PR. They look very clean. I have one request though: could we add a default implementation of the new function to the example driver? The session struct could just add a owner and token string member and use the new function to set them. Based on that example implementation, a test could be added for actually using the new method to set these parameters.

Already implemented will push it in the next commit.

I am not quite sure how far we want to take this in the examples, but I could imagine it would be useful if the new session information were actually to be used in the get_devices method for selecting which devices to return so that the new values are not only set, but also used in the examples. Let me know if you think that is taking it too far for now.

Working on it too.

Awesome! Many thanks 🙏🏼