search

Murmele / Gittyup

Understand your Git history!
https://murmele.github.io/Gittyup
MIT License
1.48k stars 109 forks source link

Show full commit diff if no file is selected in double tree view #7

Open ysalmon opened 2 years ago

ysalmon commented 2 years ago

Hi,

I just made the jump from GitAhead to Gittyup (and to Qt 5.15 !) ; it is so nice seeing this software taking a new life !

The new filelist/diff/blame interface seems promising but currently it appears to have a bug : initially, no file/folder is selected, which means that no diff gets displayed at all. I can click on the topmost folder to see the while diff of a commit, but it will unselect when I switch to a commit that applies to a different folder. It is also not easy to show the whole diff if the commit impacts several subfolders of the repo (see screen capture).

I think a simple way to solve this would be to have the filelist have an element for the root of the repo, containing everything, and having that element activated by default.

Screenshot_20211021_215410

joesponde commented 2 years ago

Hi,

I just gave a try to Gittyup and that's exactly my first analysis and my first concern.

To me, one of the most important feature is the navigation through the history of a repository. And the fact that diffs are not displayed by default is significantly slowing down user experience. Two clicks are necessary to see diffs (one on commit, one in the tree). And even more clicks are required if diffs are spread on several subfolders or root files.

The root folder seems to be an alternative to fix this but, to the cost of one more level in the tree. To avoid that additional level, all diffs could be displayed if nothing is selected in the tree. When a node is selected in the tree, only the diffs of the node would be displayed.

That said, big thanks for the work done to improve further this already great tool !

exactly-one-kas commented 1 year ago

@ysalmon your proposal to keep the selection when switching commits has already been implemented, but @joesponde's idea hasn't, so I'm renaming this issue to match that

RichardFevrier commented 1 year ago

@exactly-one-kas is I think a simple way to solve this would be to have the filelist have an element for the root of the repo, containing everything, and having that element activated by default. proposed by @ysalmon already included in your last release (development) ? I have just run the flatpak and I can not see it.

exactly-one-kas commented 1 year ago

I was talking about pre-selecting files, we currently save and restore the selection when switching commits, and select the first entry when restoring the selection yields zero entries