search

Murzchnvok / polybar-collection

Beautiful collection of Polybar themes
824 stars 47 forks source link

Hardcoded creds #11

Closed dennis-perrone closed 2 years ago

dennis-perrone commented 2 years ago

First things, thanks for the repo! I was looking at the weather.py and noticed you have your OpenWeather API key hardcoded in there. Just wanted to make you aware in the event it wasn't intentional.

Murzchnvok commented 2 years ago

Heya, yeah I intentionally did that, altho it's only gonna use it when you don't have the environment variable for the OpenWeather API key. But yeah I should update the README to let people know that you can configure that. I also should update this repo, kinda lazy now, but I'll update soon. Thanks!

dennis-perrone commented 2 years ago

No worries and thanks for the explanation and quick response. I'd just hate to see it be an accident and your API key get abused. I'm going in a slightly different direction with my project but wanted to bring it up to you! I'll close this now. Thanks again for making your work public.

Murzchnvok commented 2 years ago

Sure, thanks again!