search

MusicPlayerDaemon / MPD

Music Player Daemon
https://www.musicpd.org/
GNU General Public License v2.0
2.18k stars 351 forks source link

Tags MUSICBRAINZ_WORKID and MUSICBRAINZ_RELEASEGROUPID are not working #2057

Closed jcorporation closed 4 months ago

jcorporation commented 5 months ago

Bug report

Describe the bug

Tags MUSICBRAINZ_WORKID and MUSICBRAINZ_RELEASEGROUPID are not listed by the tagtypes command despite they are enabled in mpd.conf.

I suppose only the first 32 tags are working.

OK MPD 0.24.0
tagtypes
tagtype: Artist
tagtype: Album
tagtype: AlbumArtist
tagtype: Title
tagtype: Track
tagtype: Name
tagtype: Genre
tagtype: Date
tagtype: OriginalDate
tagtype: Composer
tagtype: Performer
tagtype: Disc
tagtype: MUSICBRAINZ_ARTISTID
tagtype: MUSICBRAINZ_ALBUMID
tagtype: MUSICBRAINZ_ALBUMARTISTID
tagtype: MUSICBRAINZ_TRACKID
tagtype: MUSICBRAINZ_RELEASETRACKID
OK
tagtypes all
OK
tagtypes
tagtype: Artist
tagtype: Album
tagtype: AlbumArtist
tagtype: Title
tagtype: Track
tagtype: Name
tagtype: Genre
tagtype: Date
tagtype: OriginalDate
tagtype: Composer
tagtype: Performer
tagtype: Disc
tagtype: MUSICBRAINZ_ARTISTID
tagtype: MUSICBRAINZ_ALBUMID
tagtype: MUSICBRAINZ_ALBUMARTISTID
tagtype: MUSICBRAINZ_TRACKID
tagtype: MUSICBRAINZ_RELEASETRACKID
OK
tagtypes enable musicbrainz_workid
OK
tagtypes
tagtype: Artist
tagtype: Album
tagtype: AlbumArtist
tagtype: Title
tagtype: Track
tagtype: Name
tagtype: Genre
tagtype: Date
tagtype: OriginalDate
tagtype: Composer
tagtype: Performer
tagtype: Disc
tagtype: MUSICBRAINZ_ARTISTID
tagtype: MUSICBRAINZ_ALBUMID
tagtype: MUSICBRAINZ_ALBUMARTISTID
tagtype: MUSICBRAINZ_TRACKID
tagtype: MUSICBRAINZ_RELEASETRACKID
OK

Expected Behavior

The tagtypes command lists all enabled tags.

Actual Behavior

The tags musicbrainz_workid and musicbrainz_releasegroupid are not listed in the output if the tagtypes command.

Version

mpd --version
Music Player Daemon 0.23.14 (0.23.14)
Copyright 2003-2007 Warren Dukes <warren.dukes@gmail.com>
Copyright 2008-2021 Max Kellermann <max.kellermann@gmail.com>
This is free software; see the source for copying conditions.  There is NO
warranty; not even MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Database plugins:
 simple proxy upnp

Storage plugins:
 local smbclient udisks nfs curl

Neighbor plugins:
 smbclient upnp udisks

Decoders plugins:
 [mad] mp3 mp2
 [mpg123] mp3
 [vorbis] ogg oga
 [oggflac] ogg oga
 [flac] flac
 [opus] opus ogg oga
 [sndfile] wav aiff aif au snd paf iff svx sf voc w64 pvf xi htk caf sd2
 [dsdiff] dff
 [dsf] dsf
 [hybrid_dsd] m4a
 [faad] aac
 [mpcdec] mpc
 [wavpack] wv
 [openmpt] mptm mod s3m xm it 669 amf ams c67 dbm digi dmf dsm dtm far imf ice j2b m15 mdl med mms mt2 mtm nst okt plm psm pt36 ptm sfx sfx2 st26 stk stm stp ult wow gdm mo3 oxm umx xpk ppm mmcmp
 [modplug] 669 amf ams dbm dfm dsm far it med mdl mod mtm mt2 okt s3m stm ult umx xm
 [mikmod] amf dsm far gdm imf it med mod mtm s3m stm stx ult uni xm
 [sidplay] sid mus str prg P00
 [wildmidi] mid
 [fluidsynth] mid
 [adplug] amd d00 hsc laa rad raw sa2
 [gme] ay gbs gym hes kss nsf nsfe rsn sap spc vgm vgz
 [ffmpeg] 16sv 3g2 3gp 4xm 8svx aa3 aac ac3 adx afc aif aifc aiff al alaw amr anim apc ape asf atrac au aud avi avm2 avs bap bfi c93 cak cin cmv cpk daud dct divx dts dv dvd dxa eac3 film flac flc fli fll flx flv g726 gsm gxf iss m1v m2v m2t m2ts m4a m4b m4v mad mj2 mjpeg mjpg mka mkv mlp mm mmf mov mp+ mp1 mp2 mp3 mp4 mpc mpeg mpg mpga mpp mpu mve mvi mxf nc nsv nut nuv oga ogm ogv ogx oma ogg omg opus psp pva qcp qt r3d ra ram rl2 rm rmvb roq rpl rvc shn smk snd sol son spx str swf tak tgi tgq tgv thp ts tsp tta xa xvid uv uv2 vb vid vob voc vp6 vmd wav webm wma wmv wsaud wsvga wv wve rtp:// rtsp:// rtsps://
 [pcm]

Filters:
 libsamplerate soxr

Tag plugins:
 id3tag

Output plugins:
 shout null fifo sndio pipe alsa ao oss openal pipewire pulse jack httpd snapcast recorder

Encoder plugins:
 null vorbis opus lame wave flac

Archive plugins:
 [bz2] bz2
 [zzip] zip
 [iso] iso

Input plugins:
 file io_uring archive alsa curl ffmpeg smbclient nfs mms cdio_paranoia

Playlist plugins:
 extm3u m3u pls xspf asx rss soundcloud flac cue embcue

Protocols:
 file:// alsa:// cdda:// ftp:// ftps:// gopher:// hls+http:// hls+https:// http:// https:// mms:// mmsh:// mmst:// mmsu:// nfs:// rtmp:// rtmpe:// rtmps:// rtmpt:// rtmpte:// rtmpts:// rtp:// rtsp:// rtsps:// scp:// sftp:// smb:// srtp://

Other features:
 avahi dbus udisks epoll icu inotify ipv6 systemd tcp un

Configuration

music_directory     "/home/juergen/musik/"
playlist_directory      "/var/lib/mpd/playlists"
database {
        plugin          "simple"
        path            "/var/lib/mpd/tag_cache"
        cache_directory "/var/lib/mpd/cache"
}
log_file            "/var/log/mpd/mpd.log"
pid_file            "/run/mpd/pid"
state_file          "/var/lib/mpd/state"
sticker_file                   "/var/lib/mpd/sticker.sql"
user                "mpd"
bind_to_address     "any"
bind_to_address     "/run/mpd/socket"
log_level           "verbose"
metadata_to_use "artist,album,albumartist,title,track,name,genre,date,originaldate,composer,performer,disc,musicbrainz_artistid,musicbrainz_albumid,musicbrainz_albumartistid,musicbrainz_trackid,musicbrainz_releasetrackid,musicbrainz_workid,musicbrainz_releasegroupid"
input {
        plugin "curl"
        verify_peer "yes"
        verify_host "yes"
}
input {
        enabled    "no"
        plugin     "qobuz"
}
input {
        enabled      "no"
        plugin       "tidal"
}
decoder {
        plugin                  "hybrid_dsd"
        enabled                 "no"
}
audio_output {
    type        "alsa"
    name        "My ALSA Device Local Soundcard"
}
audio_output {
    type        "httpd"
    name        "http"
    port        "8000"
    format      "44100:16:1"
    always_on   "yes"
}
audio_output {
    type        "null"
    name        "My Null Output 1"
}
audio_output {
    type        "null"
    name        "My Null Output 2"
}
audio_output {
    type        "null"
    name        "My Null Output 3"
}
filesystem_charset      "UTF-8"
neighbors {
    plugin "udisks"
}

Log

client: [7] opened from 127.0.0.1:44652
client: [7] process command "tagtypes"
client: [7] command returned 0
client: [7] process command "tagtypes all"
client: [7] command returned 0
client: [7] process command "tagtypes"
client: [7] command returned 0
client: [7] process command "tagtypes enable musicbrainz_workid"
client: [7] command returned 0
client: [7] process command "tagtypes"
client: [7] command returned 0
client: [7] process command "close"
client: [7] command returned 4
client: [7] closed
MaxKellermann commented 4 months ago

This was already fixed in the master branch by commit f49d4ef4ad0ae95bde0357a2c8bd3456e77a7798

jcorporation commented 4 months ago

I thought so also, but I tested with the current master branch and the issue exists in current master also.

Logs from newest test:

client: [0] opened from 127.0.0.1:56060
client: [0] process command "tagtypes clear"
client: [0] command returned 0
client: [0] process command "tagtypes"
client: [0] command returned 0
client: [0] process command "tagtypes enable musicbrainz_workid"
client: [0] command returned 0
client: [0] process command "tagtypes"
client: [0] command returned 0
tagtypes clear
OK
tagtypes
OK
tagtypes enable musicbrainz_workid
OK
tagtypes
OK

Version: 

output/mpd --version
Music Player Daemon 0.24 (v0.23.15-1410-g8d15e0fed)