search

MyHush / hush

Hush is a fork of Zcash focused on secure communications
https://myhush.org
Other
67 stars 37 forks source link

Absurd fee bug #136

Closed leto closed 6 years ago

leto commented 6 years ago

This fixes the "absurd fee bug" for small transaction amounts (when amount < fee), more details here: https://github.com/zcash/zcash/issues/3281

This directly effects HushList protocol, since HushList wants to be able to send amount=0 transactions with default fee, but Zcash upstream currently has a bug which forces a non-default fee, which leaks metadata.

Most likely all Zcash forks have this bug, except the ones that haven't merged since Zcash introduced this from BTC upstream.

leto commented 6 years ago

FYI All tests wallet.py tests pass for me on Ubuntu 16.04 . To run the tests for this PR: ./qa/pull-tester/rpc-tests.sh wallet

leto commented 6 years ago

FYI I forgot to merge this and it should be in our next release